Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncup estimation model prediction logic updates #946

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Syncup estimation model prediction logic updates #946

merged 1 commit into from
Apr 16, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) [email protected]

Fixes #945

  • update the prediction code to match latest logic changes.

@amahussein
Syncup estimation model prediction logic updates
23ce8e1 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#945

- update the prediction code to match latest logic changes.
@amahussein amahussein added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Apr 16, 2024
@amahussein amahussein self-assigned this Apr 16, 2024
parthosa
parthosa approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein.

nartal1
nartal1 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein !

@parthosa parthosa merged commit 27b1f27 into NVIDIA:dev Apr 16, 2024
16 checks passed
@parthosa parthosa deleted the spark-rapids-tools-945 branch April 16, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@nartal1 nartal1 nartal1 approved these changes

@mattahrens mattahrens Awaiting requested review from mattahrens

Assignees

@amahussein amahussein

Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Syncup estimation model prediction logic updates
3 participants
@amahussein @parthosa @nartal1